On 23/08/06, Brian Duggan <[EMAIL PROTECTED]> wrote:
> In Maypole 2.11, the test scripts (and just a
> perl -we 'use Maypole') produce warnings about
> view_object() being redefined.
>
> Seems there's both a
>
>    __PACKAGE__->mk_classdata(...view_object...)
>
> as well as this subroutine
>
>     sub view_object {
>         my $self = shift;
>         my $r    = shift;
>         return $r->parent->view_object if $r->{parent};
>         return $self->NEXT::DISTINCT::view_object( $r, @_ );
>     }
>
> in Maypole.pm.
>
> Can the subroutine just be removed?

I could remove the entry from mk_classdata, as it's pretty much
redundant (it provides get/set_view_object, which aren't used), it
might actually be worth renaming the mk_classdata entry to
_view_object to make it clearer and stop the warnings.

The view_object method is called within the component sub, so needs to
be able to revert up to the parent request.

cheers,

A.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Maypole-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/maypole-devel

Reply via email to