Hello! > > Why did you add "#ifdef HAVE_SYNTAXH"? It is always defined, but it's > > kept in the code to make it easy to disable syntax highlighting. I > > think we should remove this option if it stands in the way, as well as > > the "OA" definition, which is always 1. > > I don't understand you. You told me to download the editoptions.c from > the CVS version.
When? I don't remember that. Check your facts. In fact, I believe that it's wrong to download some files from CVS. Either you work with CVS or you don't. If you mean this message: http://mail.gnome.org/archives/mc-devel/2002-November/msg00075.html it wasn't written by me. > I did it. HAVE_SYNTAXH was there. >From your patch: quick_widgets[5].str_result = &q; +#ifdef HAVE_SYNTAXH quick_widgets[5 + OA].result = &tedit_syntax_highlighting; Plus means that you are adding this line. That's what diffs are for. You see what was added and what was removed. If you don't do it, then somebody else should do it for you. Please note that no testing can find all bugs. If you add or remove something and you understand why you are doing it, it's fine. But if you are adding or removing code without even realizing it, then it's not OK. Your code will need to be rechecked more carefully, maybe even rewritten. This particular change is not important, because HAVE_SYNTAXH is always 1. But it's wasn't the case before I added syntax highlighting for mc compiled with ncurses library. > You told, YOU OPTIMIZED it. I don't remember that. It's better that you write message instead of ten, but put your facts straight. > And now, you ask me about a thing, I just used to make the code > consequence. Where the hell I should know that you would like to remove > this option, and I should do that??? You misunderstood me. You are not supposed to know that. I offered to make a cleanup so that your patch would not need to include those parts. Actually, this is a minor issue. I can easily do it. Anyway, I think I'll try to apply this patch before the release. The idea is good, the implementation is basically OK, the changes are not too intrusive. -- Regards, Pavel Roskin _______________________________________________ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
