Hello Denis,
On Tue, 25 Jul 2006, Denis Vlasenko wrote:
> On Tuesday 25 July 2006 18:15, Andy Shevchenko wrote:
>> Denis Vlasenko wrote:
>>>> What the main idea for removing spaces is here?
>>> To make indentation more consistent across extfs scripts
>> IIRC the whitespaces moving is a bad idea at least here (in mc code).
>> May be Pavel corrects me.
>
> Nix the whitespace patch, I don't care much. (wow...)
>
> Apply at least quoting fixes, ok?
The hunks below weren't applied - the rest are in CVS.
If someone thinks that these hunks are indeed necessary I'll
check them in.
diff -urpN mc-4.6.1.org/vfs/extfs/audio.in mc-4.6.1.extfs/vfs/extfs/audio.in
--- mc-4.6.1.org/vfs/extfs/audio.in 2004-11-10 17:08:00.000000000 +0100
+++ mc-4.6.1.extfs/vfs/extfs/audio.in 2006-07-25 14:48:18.000000000 +0200
@@ -19,7 +19,7 @@ audiofs_list()
cdparanoia -Q -d "$1" 2>&1 | grep '^[ 0-9][ 0-9][ 0-9]\.' | while read A
B C
do
A=`echo "$A" | sed -e 's/\.//' -e 's/^\(.\)$/0\1/'`
- SIZE=`expr 44 + $B \* 2352`
+ SIZE=`expr 44 + "$B" \* 2352`
echo "-r--r--r-- 1 0 0 $SIZE $DATE track-${A}.wav"
done
}
diff -urpN mc-4.6.1.org/vfs/extfs/iso9660.in mc-4.6.1.extfs/vfs/extfs/iso9660.in
--- mc-4.6.1.org/vfs/extfs/iso9660.in 2004-10-29 11:14:38.000000000 +0200
+++ mc-4.6.1.extfs/vfs/extfs/iso9660.in 2006-07-25 14:48:18.000000000 +0200
@@ -11,7 +11,7 @@
test_iso () {
CHARSET=`echo "$save_ctype" | sed -n -e 's/.*\.\(.*\)"$/\1/p' | tr
'[A-Z]' '[a-z]'`
if test -n "$CHARSET"; then
- isoinfo -j $CHARSET 2>&1 | grep "Unknown charset" >/dev/null && CHARSET=
+ isoinfo -j "$CHARSET" 2>&1 | grep "Unknown charset" >/dev/null &&
CHARSET=
fi
if test -n "$CHARSET"; then
JOLIET_OPT="-j $CHARSET -J"
_______________________________________________
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
