#247: mhl: realloc() -> malloc() when NULL passed
----------------------+-----------------------------------------------------
Reporter: metux | Owner: metux
Type: defect | Status: accepted
Priority: major | Milestone: 4.6.3
Component: mc-core | Version: 4.6.2
Resolution: | Keywords: rework
Blocking: | Blockedby:
----------------------+-----------------------------------------------------
Changes (by winnie):
* keywords: review vote-slavazanko => rework
Comment:
Fix is okay.. but commit msg isn't. I've rewrote this and have done a
forced push. Please update your working copyies..
Furthermore:
In file included from ../../mhl/string.h:7,
from ../../edit/usermap.c:33:
../../mhl/memory.h: In function ‘mhl_mem_realloc’:
../../mhl/memory.h:27: warning: type of ‘ptr’ defaults to ‘int’
../../mhl/memory.h:27: warning: type of ‘sz’ defaults to ‘int’
../../mhl/memory.h:28: warning: implicit declaration of function
‘mhl_mem_alloc’
../../mhl/memory.h:28: warning: return makes pointer from integer without
a cast
../../mhl/memory.h:29: warning: passing argument 1 of ‘realloc’ makes
pointer from integer without a cast
Sorry no vote from me.
Btw: slavaz where are your fixes.. the last commit in the 247_ branch is
from Enrico from 4. Feb...?
--
Ticket URL: <www.midnight-commander.org/ticket/247#comment:6>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center
_______________________________________________
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
