On Mon, 18 Jan 2021 04:38:10 +0100 David Haller wrote: > Hello, Hi!
Thanks for testing. > On Sun, 10 Jan 2021, Yury V. Zaytsev wrote: > >TLDR; I would appreciate if you could please test the following tarball on > >your systems and report any blocker regressions as compared to the previous > >4.8.25 release: > > Two things: > > 1. mcedit causes a SIGSEGV when jumping out via Ctrl-o, even if just > too _look_ at stuff, not doing anything on the (sub-)shell: Confirmed. I'll fix this today. > 2. I don't know if that's a current regression or if that already was > the case in 4.8.25 and earlier: if compiled without slang, no mouse > actions work anymore (has the curses code gone?) > > I can do more debugging if you can't pinpoint the change... This is known: https://midnight-commander.org/ticket/4144 > 3.: you should add the version to AC_INIT, so that PACKAGE_VERSION > gets set correctly during configure. If not, generated docs have > 'mc-' instead of 'mc-$VERSION' (e.g. mc-4.8.25) as version in e.g. > the pdf ;) This is known too: https://midnight-commander.org/ticket/3603 > A possible patch might be: > > ==== mc-4.8.26-fix_ac_version.patch ==== > diff '-bpurNx*~' g/configure.ac h/configure.ac > --- g/configure.ac 2021-01-10 12:50:16.000000000 +0100 > +++ h/configure.ac 2021-01-11 13:56:25.382961865 +0100 > @@ -3,7 +3,8 @@ dnl Configure.in file for the Midnight C > dnl > > AC_PREREQ(2.60) > -AC_INIT([GNU Midnight Commander], [], [mc-devel@gnome.org]) > +m4_define(pkg_VERSION,[m4_esyscmd([sh ./ver.sh])]) > +AC_INIT([GNU Midnight Commander], [pkg_VERSION], [mc-devel@gnome.org]) > m4_pattern_forbid(MC_) > AC_CONFIG_MACRO_DIR([m4]) > AC_CONFIG_AUX_DIR(config) > diff '-bpurNx*~' g/ver.sh h/ver.sh > --- g/ver.sh 1970-01-01 01:00:00.000000000 +0100 > +++ h/ver.sh 2021-01-11 13:54:30.000000000 +0100 > @@ -0,0 +1,2 @@ > +#!/bin/sh > +awk -F'"' '/MC_CURRENT_VERSION/{printf("%s",$2);}' version.h > ==== > > (not using the external script get's you into quoting hell ;) > > I've seen that it's somewhat redundant, but possible the later setting > of the version from version.h can be removed then, I've not looked > into that yet. -- Andrew _______________________________________________ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
