Hello, Andrew!

> In this patch I rely all egreps have -i option for case insensitive search

The idea is great. I hope to see this feature in MC when the patch is
mature.

However, there are some issues with the patch:

1) There is no ChangeLog entry.

2) It's probably better to use "-i -n" instead of "-in" because of
portability issues - it's safer not to rely on the support for option
clustering.

3) It breaks the "Find file" dialog in the GNOME edition. This patch
should be sufficient to fix it (but tab navigation is still broken):
_________________________________________
--- gnome/layout
+++ gnome/layout
@@ -85,6 +85,10 @@
 geometry=2,2,1,1
 flags=

+[findfile-Widget-find-case-check]
+geometry=3,5,1,1
+flags=
+
 [hotlist-Widget-e]
 geometry=3,12,1,1
 flags=ew
_________________________________________

4) Search with a pattern doesn't work in GNOME at all. It looks like that
GMC fails to run egrep. I understand that it's not your bug, but I don't
like adding new features on top of the existing bugs.

Regards,
Pavel Roskin

Reply via email to