Henning Snater has submitted this change and it was merged. Change subject: Behavior fix in site suggestion for site links ......................................................................
Behavior fix in site suggestion for site links As Denny requested, I changed the behavior of the sitelink interface so the first suggested entry from the suggestions list is chosen as the site when leaving the field. Some minor, related cleanup was done as well. patchset 2: (tgritschacher) changed the selenium test to check this functionality too; also simplified sitelink tests a bit; Change-Id: Ic8e7d85365d8facf0b41233295feaf7755523c51 --- M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.AutocompleteInterface.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.js M repo/tests/selenium/spec/sitelinks/sitelinks_spec.rb 4 files changed, 41 insertions(+), 35 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14683 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8e7d85365d8facf0b41233295feaf7755523c51 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
