Tobias Gritschacher has submitted this change and it was merged. Change subject: Changes after review of API ......................................................................
Changes after review of API Data integrity in wbsetitem, previously it was basically none, it will now only store values that it recognizes. Also site ids and language ids are checked, and the values are normalized. There is no implicit creation of items anymore, all items must be created through explicit calls to wbsetitem. It is possible to turn on deletion of empty items. This is not tested. How to handle deletion needs further investigation, especially the rights part. Use of the parameters item, link and attribute is removed. Some permissions that doesn't give any meaning anymore was removed, and some other was renamed. Patchset 3: Deleted files breaks tests. Patchset 4: Mostly whitespace and removing unused code. Patchset 5: Fixed an erroneous example URL in wbsetitem. patchset 6: UI changes to create item logic to go along with API changes patchset 7: fixed commit message patchset 8: whitespaces and removed unused code Patchset 11: Grrrr... Patchset 12: Now usekeys are true in the config. Patchset 13: Removed usekeys from an URL in the user interface Change-Id: I4a66af658dd1ac8cf4a044c3fde0e6857418fd91 --- M lib/includes/Item.php M lib/includes/ItemObject.php M repo/Wikibase.hooks.php M repo/Wikibase.i18n.php M repo/Wikibase.php M repo/includes/api/Api.php D repo/includes/api/ApiDeleteLanguageAttribute.php D repo/includes/api/ApiGetItemId.php M repo/includes/api/ApiGetItems.php D repo/includes/api/ApiGetSiteLinks.php M repo/includes/api/ApiModifyItem.php M repo/includes/api/ApiSetAliases.php M repo/includes/api/ApiSetItem.php M repo/includes/api/ApiSetLanguageAttribute.php R repo/includes/api/ApiSetSiteLink.php M repo/maintenance/importInterlang.php M repo/resources/wikibase.ui.PropertyEditTool.EditableDescription.js M repo/resources/wikibase.ui.PropertyEditTool.EditableLabel.js M repo/resources/wikibase.ui.PropertyEditTool.EditableSiteLink.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.js M repo/tests/phpunit/includes/api/ApiJSONPCompleteTest.php M repo/tests/phpunit/includes/api/ApiJSONPTest.php M repo/tests/phpunit/includes/api/ApiLanguageAttributeTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiPermissionsTest.php M repo/tests/phpunit/includes/api/ApiSetAliasesTest.php M repo/tests/phpunit/includes/api/ApiSetItemTest.php R repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php 28 files changed, 801 insertions(+), 1,131 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14762 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a66af658dd1ac8cf4a044c3fde0e6857418fd91 Gerrit-PatchSet: 13 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad <john.b...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de> Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
