Mark Bergsma has submitted this change and it was merged.
Change subject: FlexeLint spotted a memory leak in Tollefs "admin-health" code,
so I started fixing that, and then I fixed another couple of nits and polished
the naming a bit and ...
......................................................................
FlexeLint spotted a memory leak in Tollefs "admin-health" code, so I
started fixing that, and then I fixed another couple of nits and polished
the naming a bit and ...
Well, you know how it is.
Changed the backend matching function to take a call-back function
to eliminate the need for the memory which got leaked.
This meant that backend.list could also use it, if only the parsing
code accepted a blank input.
So I rewrote the parsing code to also allow empty names, so you can:
backend.list (:80)
backend.list (192.168)
etc.
And then I added a summary report of the probing, if it is happening,
and explicitly say that no probing is happening if it isn't.
---
M bin/varnishd/cache_backend.c
M bin/varnishd/cache_backend.h
M bin/varnishd/cache_backend_cfg.c
M bin/varnishd/cache_backend_poll.c
M bin/varnishtest/tests/c00048.vtc
5 files changed, 199 insertions(+), 127 deletions(-)
Approvals:
Mark Bergsma: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/14993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia17060fd4574ce51ee721073f2a192aaa68fd7d0
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/varnish
Gerrit-Branch: testing/persistent
Gerrit-Owner: Mark Bergsma <m...@wikimedia.org>
Gerrit-Reviewer: Mark Bergsma <m...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
