Nikerabbit has submitted this change and it was merged. Change subject: Use Xml::languageSelector in SpecialAllmessages ......................................................................
Use Xml::languageSelector in SpecialAllmessages Improve Xml::languageSelector: add parameters to change label message and id/name of the select tag. Use languageSelector in SpecialAllmessages (less code duplication) Patchset 10 July: add tests per MaxSem; add version for new parameters and change the message parameter to require a Message object per Nikerabbit Change-Id: I7fbb29ee2dc37a2b6a5e2cfc88207a0b47b83e9b --- M includes/Xml.php M includes/specials/SpecialAllmessages.php M tests/phpunit/includes/XmlTest.php 3 files changed, 30 insertions(+), 24 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/7231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fbb29ee2dc37a2b6a5e2cfc88207a0b47b83e9b Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: SPQRobin <robinp.1...@gmail.com> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: SPQRobin <robinp.1...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
