Nikerabbit has submitted this change and it was merged.
Change subject: Make separate functions for better code readability
......................................................................
Make separate functions for better code readability
Call analyzePrefix with a title objects which checks namespaces.
Make a separate function for the second part of onShowMissingArticle. So the
biggest part of the commit is just decreasing the indenting.
In general, instead of "if( no info page ) { do 1; return; } do 2;" it is now
"if( info page ) { call other function for 2; return; } do 1"
Change-Id: I8367f99a8e23eda4034d6e1b51afc477cb284f92
---
M IncubatorTest.php
1 file changed, 53 insertions(+), 53 deletions(-)
Approvals:
Nikerabbit: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/7990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8367f99a8e23eda4034d6e1b51afc477cb284f92
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/WikimediaIncubator
Gerrit-Branch: master
Gerrit-Owner: SPQRobin <robinp.1...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: SPQRobin <robinp.1...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
