Trevor Parscal has submitted this change and it was merged.
Change subject: Kranitor #1: On-boarding
......................................................................
Kranitor #1: On-boarding
'''Kranitor commits''' are commits by Krinkle with his janitor hat on.
Must never contain functional changes mixed with miscellaneous changes.
.gitignore:
* Add .DS_Store to the ignore list so that browsing the directories
on Mac OS X, will not add these files to the list of untracked
files.
* Fix missing newline at end of file
.jshintrc
* raises -> throws
* +module (QUnit.module)
* remove 'Node' (as of node-jshint 1.7.2 this is now part of
'browser:true', as it should be)
Authors:
* Adding myself
MWExtension/VisualEditor.php
* Fix default value of wgVisualEditorParsoidURL to not
point to the experimental instance in WMF Labs.
Issues:
* ve.ce.TextNode:
- Fix TODO: Don't perform a useless clone of an already-jQuerified object.
- Use .html() to set html content instead of encapsulating between
two strings. This is slightly faster but more importantly safer,
and prevents situations where the resulting jQuery collection
actually contains 2 elements instead of 1, thus messing up
what .contents() is iterating over.
* ve.ce.Document.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.Document.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.Transaction.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.TransactionProcessor.test.js
- Fix: ReferenceError: assert is not defined
* ext.visualEditor.viewPageTarget
- Missing dependency on 'mediawiki.Title'
Code conventions / Misc cleanup
* Various JSHint warnings.
* Whitespace
* jQuery(): Use '<tag>' for element creation,
use '<valid><xml/></valid>' for parsing
* Use the default operator instead of ternary when the condition and
first value are the same.
x = foo ? foo : bar; -> x = foo || bar;
Because contrary to some programming language (PHP...), in JS the
default operator does not enforce a boolean result but returns the
original value, hence it being called the 'default' operator, as
opposed to the 'or' operator.
* No need to call addClass() twice, it takes a space-separated list
(jQuery splits by space and adds if needed)
* Use .on( event[, selector], fn ) instead of the deprecated
routers to it such as .bind(), .delegate() and .live().
All these three are now built-in and fully compatible with .on()
* Add 'XXX:' comments for suspicious code that I don't want to change
as part of a clean up commit.
* Remove unused variables (several var x = this; where x was not
used anywhere, possibly from boilerplate copy/paste)
* Follows-up Trevor's commit that converts test suites to the new
QUnit format. Also removed the globals since we no longer use those
any more.
Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
---
M .gitignore
M .jshintrc
M AUTHORS.txt
M VisualEditor.php
M modules/ve/ce/nodes/ve.ce.TextNode.js
M modules/ve/ce/ve.ce.Surface.js
M modules/ve/dm/ve.dm.BranchNode.js
M modules/ve/dm/ve.dm.DocumentSynchronizer.js
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
M modules/ve/test/ce/nodes/ve.ce.TextNode.test.js
M modules/ve/test/ce/ve.ce.BranchNode.test.js
M modules/ve/test/ce/ve.ce.Document.test.js
M modules/ve/test/ce/ve.ce.LeafNode.test.js
M modules/ve/test/ce/ve.ce.Node.test.js
M modules/ve/test/ce/ve.ce.NodeFactory.test.js
M modules/ve/test/ce/ve.ce.test.js
M modules/ve/test/dm/nodes/ve.dm.TextNode.test.js
M modules/ve/test/dm/ve.dm.BranchNode.test.js
M modules/ve/test/dm/ve.dm.Converter.test.js
M modules/ve/test/dm/ve.dm.Document.test.js
M modules/ve/test/dm/ve.dm.DocumentSynchronizer.test.js
M modules/ve/test/dm/ve.dm.LeafNode.test.js
M modules/ve/test/dm/ve.dm.Node.test.js
M modules/ve/test/dm/ve.dm.NodeFactory.test.js
M modules/ve/test/dm/ve.dm.Surface.test.js
M modules/ve/test/dm/ve.dm.Transaction.test.js
M modules/ve/test/dm/ve.dm.TransactionProcessor.test.js
M modules/ve/test/ve.BranchNode.test.js
M modules/ve/test/ve.Document.test.js
M modules/ve/test/ve.Factory.test.js
M modules/ve/test/ve.Node.test.js
M modules/ve/test/ve.qunit.js
M modules/ve/ui/inspectors/ve.ui.LinkInspector.js
M modules/ve/ui/tools/ve.ui.ButtonTool.js
M modules/ve/ui/tools/ve.ui.ClearButtonTool.js
M modules/ve/ui/tools/ve.ui.DropdownTool.js
M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js
M modules/ve/ui/tools/ve.ui.ListButtonTool.js
M modules/ve/ui/ve.ui.Context.js
M modules/ve/ui/ve.ui.Inspector.js
M modules/ve/ui/ve.ui.Menu.js
M modules/ve/ui/ve.ui.Toolbar.js
M modules/ve/ve.Node.js
M modules/ve/ve.Surface.js
44 files changed, 802 insertions(+), 712 deletions(-)
Approvals:
Trevor Parscal: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/16836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <ttij...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
