Aaron Schulz has submitted this change and it was merged. Change subject: Improve detection of php binary. ......................................................................
Improve detection of php binary. - Add php binary and a program which might be set as $PHP. - Check for the correct php version. The break shell builtin is not too commonly used, but should beperfectly safe to use, since it's specified by POSIX http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#break Change-Id: Iefbe991426f0e9a7178363a30b613f57110e1953 --- M maintenance/dev/includes/php.sh 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefbe991426f0e9a7178363a30b613f57110e1953 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Platonides <platoni...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Platonides <platoni...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
