Umherirrender has uploaded a new change for review. Change subject: Fix wrong return value in Preprocessor::getChildrenOfType ......................................................................
Fix wrong return value in Preprocessor::getChildrenOfType I am not sure, but this looks wrong, because it adds the type to the array and not the child. This method is unused in core and wmf extensions, maybe removing/deprecating is a better idea, but I am not sure, if that is possible. I have only see this possible error, while looking through the preprocessor. Change-Id: I5b7492d455989a8a3e71b5db6d31091b986c502a --- M includes/parser/Preprocessor_Hash.php M includes/parser/Preprocessor_HipHop.hphp 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/70/17770/1 -- To view, visit https://gerrit.wikimedia.org/r/17770 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b7492d455989a8a3e71b5db6d31091b986c502a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
