Brian Wolff has uploaded a new change for review. Change subject: (bug 39431) Fix how SVG metadata is displayed (esp. animated status) ......................................................................
(bug 39431) Fix how SVG metadata is displayed (esp. animated status) (Quite a few of these issues are my fault from 65c27ddeb19757cb8a) *All fields were starting as collapsed, which was not the intent of the code *Animated field used non-existent messages, and displayed a value of "1" instead of something meaningful to the user. Both (A)PNG and GIF handlers put the animated status in the long description which feels more natural to me so move the animated status to the long desc (long desc = subtitle under the image on the description page). *Use human readable file sizes in the long description instead of total number of bytes. This bring it in line with the implementation in the parent class. *Correctly mark scripted SVG's as animated. Mostly a moot point since we do not allow animated svgs past the upload checks but for completeness and for people who totally disable all upload verification. (Note: This would miss event attributes (onclick, etc) I didn't see much point in adding that since almost always there will be a script tag) Change-Id: Ic58efbf2bf1e4b14e3129e5bce9ea920d9804111 --- M RELEASE-NOTES-1.20 M includes/media/SVG.php M includes/media/SVGMetadataExtractor.php M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M maintenance/language/messages.inc 6 files changed, 40 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/56/20656/1 -- To view, visit https://gerrit.wikimedia.org/r/20656 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic58efbf2bf1e4b14e3129e5bce9ea920d9804111 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Brian Wolff <bawolff...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits