John Erling Blad has submitted this change and it was merged. Change subject: Make permission checks via EditEntity. ......................................................................
Make permission checks via EditEntity. Refactored permission checks in EntityContent, integrated them into EditEntity, wroite test cases to make sure permissions are always checked and also work for items that have not yet been saved. Change-Id: I01ef4b6860a5679eb775e681bff2aa2c527de8bb --- M repo/includes/EditEntity.php M repo/includes/content/EntityContent.php M repo/includes/content/ItemContent.php M repo/tests/phpunit/includes/EditEntityTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiPermissionsTest.php M repo/tests/phpunit/includes/content/ItemContentTest.php 7 files changed, 419 insertions(+), 107 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22548 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01ef4b6860a5679eb775e681bff2aa2c527de8bb Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
