Aarcos has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96682
Change subject: Load image only if data was returned, otherwise do nothing.
......................................................................
Load image only if data was returned, otherwise do nothing.
Change-Id: If34f52035df3129fae360bccfdc7c694a2c15a7d
---
M resources/ext.multimediaViewer/ext.multimediaViewer.js
1 file changed, 12 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/82/96682/1
diff --git a/resources/ext.multimediaViewer/ext.multimediaViewer.js
b/resources/ext.multimediaViewer/ext.multimediaViewer.js
index 6b8dc9b..630032d 100755
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.js
@@ -154,18 +154,21 @@
var imageInfo, innerInfo,
image = new Image();
- $.each( data.query.pages, function ( i, page ) {
- imageInfo = page;
- return false;
- } );
+ // Load image only if data was returned.
+ if (data.query && data.query.pages) {
+ $.each( data.query.pages, function ( i,
page ) {
+ imageInfo = page;
+ return false;
+ } );
- innerInfo = imageInfo.imageinfo[0];
+ innerInfo = imageInfo.imageinfo[0];
- image.onload = function () {
- ui.replaceImageWith( image );
- };
+ image.onload = function () {
+ ui.replaceImageWith( image );
+ };
- image.src = innerInfo.thumburl || innerInfo.url;
+ image.src = innerInfo.thumburl ||
innerInfo.url;
+ }
} );
return false;
--
To view, visit https://gerrit.wikimedia.org/r/96682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If34f52035df3129fae360bccfdc7c694a2c15a7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Aarcos <aarcos.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
