Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/97143
Change subject: Hygiene: Fix references
......................................................................
Hygiene: Fix references
* Drop the mf prefix
* Put JS in a folder like other modules
* Separate reference specific CSS from notifications to fix bug 57409
Change-Id: I99beea7ebe87b92ae2e4ecb0573a159df70f107c
---
M includes/Resources.php
R javascripts/modules/references/references.js
M less/common/notifications.less
A less/modules/references.less
4 files changed, 40 insertions(+), 24 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/43/97143/1
diff --git a/includes/Resources.php b/includes/Resources.php
index c3f1033..cf19139 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -689,8 +689,6 @@
'uploads/PhotoUploaderButton',
'ctaDrawer',
- // mf-references.js
- 'ReferencesDrawer',
'modules/tutorials/PageActionOverlay',
),
'scripts' => array(
@@ -741,6 +739,24 @@
),
),
+ 'mobile.references' => $wgMFMobileResourceBoilerplate + array(
+ 'dependencies' => array(
+ 'mobile.templates',
+ 'mobile.startup',
+ 'mobile.stable.common',
+ ),
+ 'styles' => array(
+ 'less/modules/references.less',
+ ),
+ 'templates' => array(
+ // references.js
+ 'ReferencesDrawer',
+ ),
+ 'scripts' => array(
+ 'javascripts/modules/references/references.js',
+ ),
+ ),
+
'mobile.stable' => $wgMFMobileResourceBoilerplate + array(
'dependencies' => array(
'mobile.startup',
@@ -748,6 +764,7 @@
'mediawiki.util',
'mobile.stable.styles',
'mobile.templates',
+ 'mobile.references',
'mediawiki.language',
),
'scripts' => array(
@@ -758,7 +775,6 @@
'javascripts/modules/uploads/lead-photo-init.js',
'javascripts/modules/mainmenutweaks.js',
'javascripts/modules/mf-watchstar.js',
- 'javascripts/modules/mf-references.js',
'javascripts/common/ContentOverlay.js',
'javascripts/modules/tutorials/PageActionOverlay.js',
'javascripts/modules/tutorials/newbieEditor.js',
diff --git a/javascripts/modules/mf-references.js
b/javascripts/modules/references/references.js
similarity index 100%
rename from javascripts/modules/mf-references.js
rename to javascripts/modules/references/references.js
diff --git a/less/common/notifications.less b/less/common/notifications.less
index 609970f..eaac2e4 100644
--- a/less/common/notifications.less
+++ b/less/common/notifications.less
@@ -88,24 +88,3 @@
color: #F7F737;
}
}
-
-.references {
- h3 {
- margin: 0;
- padding-right: 4px;
- display: inline;
- }
-
- .mw-cite-backlink {
- display: none;
- }
-
- button {
- float: right;
- margin-top: .7em;
- width: 16px;
- height: 12px;
- background: url(../common/images/close-button-beta.png)
no-repeat 0 50%;
- .background-size( auto, 12px );
- }
-}
diff --git a/less/modules/references.less b/less/modules/references.less
new file mode 100644
index 0000000..62080fb
--- /dev/null
+++ b/less/modules/references.less
@@ -0,0 +1,21 @@
+@import "../mixins.less";
+.references {
+ h3 {
+ margin: 0;
+ padding-right: 4px;
+ display: inline;
+ }
+
+ .mw-cite-backlink {
+ display: none;
+ }
+
+ button {
+ float: right;
+ margin-top: .7em;
+ width: 16px;
+ height: 12px;
+ background: url(../common/images/close-button-beta.png)
no-repeat 0 50%;
+ .background-size( auto, 12px );
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/97143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99beea7ebe87b92ae2e4ecb0573a159df70f107c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
