jenkins-bot has submitted this change and it was merged.
Change subject: Fix fatal
......................................................................
Fix fatal
PHP Fatal error: Call to a member function getLocalUrl() on a
non-object in
/usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php
on line 94
Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232
(cherry picked from commit 160013d74367a4f7c3407986493008f437b64211)
---
M includes/specials/SpecialHistory.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Awjrichards: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialHistory.php
b/includes/specials/SpecialHistory.php
index 7fc0224..6b63ab1 100644
--- a/includes/specials/SpecialHistory.php
+++ b/includes/specials/SpecialHistory.php
@@ -90,7 +90,7 @@
$canSeeText = $rev->userCan( Revision::DELETED_TEXT, $user );
if ( $canSeeText && $prev && $prev->userCan(
Revision::DELETED_TEXT, $user ) ) {
$diffLink = SpecialPage::getTitleFor( 'MobileDiff',
$prev->getId() )->getLocalUrl();
- } elseif ( $canSeeText ) {
+ } elseif ( $canSeeText && $rev->getTitle() !== null ) {
$diffLink = $rev->getTitle()->getLocalUrl( array(
'oldid' => $rev->getId() ) );
} else {
$diffLink = false;
--
To view, visit https://gerrit.wikimedia.org/r/97152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf4
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
