Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/97162
Change subject: Create a fresh Title object in the job
......................................................................
Create a fresh Title object in the job
In some cases one project's interwiki prefix might
be a namespace on another. For example, [[wikidata:]]
on Meta is an interwiki prefix, but on Wikidata itself
it is a namespace. By creating a fresh title object
we avoid losing the namespace.
Bug: 57464
Change-Id: I6e7d970473a86a1c6b2fb4f0f54019a2a2407458
---
M MassMessageJob.php
M MassMessageSubmitJob.php
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage
refs/changes/62/97162/1
diff --git a/MassMessageJob.php b/MassMessageJob.php
index 21b1ec9..b8f80d0 100644
--- a/MassMessageJob.php
+++ b/MassMessageJob.php
@@ -21,6 +21,9 @@
* @return bool
*/
public function run() {
+ // Create a fresh Title object so interwiki prefixes and
namespaces
+ // dont get confused. Bug 57464
+ $this->title = Title::newFromText( $this->params['title'] );
$status = $this->sendMessage();
if ( $status !== true ) {
diff --git a/MassMessageSubmitJob.php b/MassMessageSubmitJob.php
index ca25805..36f748c 100644
--- a/MassMessageSubmitJob.php
+++ b/MassMessageSubmitJob.php
@@ -25,6 +25,7 @@
foreach ( $pages as $page ) {
$title = Title::newFromText( $page['title'] );
+ $data['title'] = $page['title'];
$jobsByTarget[$page['wiki']][] = new MassMessageJob(
$title, $data );
}
--
To view, visit https://gerrit.wikimedia.org/r/97162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e7d970473a86a1c6b2fb4f0f54019a2a2407458
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
