jenkins-bot has submitted this change and it was merged.
Change subject: Make WebRequest::protocol protected as it's used in subclasses
in the same file
......................................................................
Make WebRequest::protocol protected as it's used in subclasses in the same file
Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e
---
M includes/WebRequest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index 536ce12..46cba52 100644
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -54,7 +54,7 @@
* Cached URL protocol
* @var string
*/
- private $protocol;
+ protected $protocol;
public function __construct() {
/// @todo FIXME: This preemptive de-quoting can interfere with
other web libraries
--
To view, visit https://gerrit.wikimedia.org/r/97168
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
