jenkins-bot has submitted this change and it was merged.
Change subject: Don't use @deprecated for parameters
......................................................................
Don't use @deprecated for parameters
Makes Doxygen think the whole function is deprecated,
switched them to "@param $var type deprecated"
Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818
---
M formatters/BasicFormatter.php
M formatters/PageLinkFormatter.php
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php
index cdf442e..8d3bce3 100644
--- a/formatters/BasicFormatter.php
+++ b/formatters/BasicFormatter.php
@@ -152,7 +152,7 @@
*
* @param $event EchoEvent that the notification is for.
* @param $user User to format the notification for.
- * @deprecated $type
+ * @param $type string deprecated
*/
protected function applyChangeBeforeFormatting( EchoEvent $event, User
$user, $type ) {
// Use the bundle message if use-bundle is true and there is a
bundle message
@@ -257,7 +257,7 @@
*
* @param $event EchoEvent
* @param $user User
- * @deprecated $type
+ * @param $type string deprecated
* @return array
*/
protected function formatEmail( $event, $user, $type ) {
@@ -534,7 +534,7 @@
* Get raw bundle data for an event so it can be manipulated
* @param $event EchoEvent
* @param $user User
- * @deprecated $type
+ * @param $type string deprecated
* @return ResultWrapper|bool
*/
protected function getRawBundleData( $event, $user, $type ) {
@@ -565,7 +565,8 @@
* this function to use a differnt group iterator such as title,
namespace
* @param $event EchoEvent
* @param $user User
- * @deprecated $type
+ * @param $type string deprecated
+ * @throws MWException
*/
protected function generateBundleData( $event, $user, $type ) {
global $wgEchoMaxNotificationCount;
diff --git a/formatters/PageLinkFormatter.php b/formatters/PageLinkFormatter.php
index cdec629..816777b 100644
--- a/formatters/PageLinkFormatter.php
+++ b/formatters/PageLinkFormatter.php
@@ -37,7 +37,7 @@
* link from Page B and X other pages
* @param $event EchoEvent
* @param $user User
- * @deprecated $type
+ * @param $type string deprecated
*/
protected function generateBundleData( $event, $user, $type ) {
global $wgEchoMaxNotificationCount;
--
To view, visit https://gerrit.wikimedia.org/r/97184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
