Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/97345
Change subject: Let maintenance class start with a upper case letter ...................................................................... Let maintenance class start with a upper case letter the case of a class is not a argument for php, but upper case letters are recommend. Change-Id: Ibc9169b238ee3f73021e8f73188c3e5b5f1d36a3 --- M maintenance/mctest.php M maintenance/nextJobDB.php M maintenance/userOptions.inc M maintenance/userOptions.php 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/45/97345/1 diff --git a/maintenance/mctest.php b/maintenance/mctest.php index eda101e..243f97c 100644 --- a/maintenance/mctest.php +++ b/maintenance/mctest.php @@ -30,7 +30,7 @@ * * @ingroup Maintenance */ -class mcTest extends Maintenance { +class McTest extends Maintenance { public function __construct() { parent::__construct(); $this->mDescription = "Makes several 'set', 'incr' and 'get' requests on every" @@ -111,5 +111,5 @@ } } -$maintClass = "mcTest"; +$maintClass = "McTest"; require_once RUN_MAINTENANCE_IF_MAIN; diff --git a/maintenance/nextJobDB.php b/maintenance/nextJobDB.php index 219b5d8..06ccccb 100644 --- a/maintenance/nextJobDB.php +++ b/maintenance/nextJobDB.php @@ -28,7 +28,7 @@ * * @ingroup Maintenance */ -class nextJobDB extends Maintenance { +class NextJobDB extends Maintenance { public function __construct() { parent::__construct(); $this->mDescription = "Pick a database that has pending jobs"; @@ -115,5 +115,5 @@ } } -$maintClass = "nextJobDb"; +$maintClass = "NextJobDb"; require_once RUN_MAINTENANCE_IF_MAIN; diff --git a/maintenance/userOptions.inc b/maintenance/userOptions.inc index f198167..f497f2a 100644 --- a/maintenance/userOptions.inc +++ b/maintenance/userOptions.inc @@ -30,7 +30,7 @@ /** * @ingroup Maintenance */ -class userOptions { +class UserOptions { public $mQuick; public $mQuiet; public $mDry; @@ -43,7 +43,7 @@ /** Constructor. Will show usage and exit if script options are not correct */ function __construct( $opts, $args ) { if ( !$this->checkOpts( $opts, $args ) ) { - userOptions::showUsageAndExit(); + UserOptions::showUsageAndExit(); } else { $this->mReady = $this->initializeOpts( $opts, $args ); } diff --git a/maintenance/userOptions.php b/maintenance/userOptions.php index e0de357..53db48c 100644 --- a/maintenance/userOptions.php +++ b/maintenance/userOptions.php @@ -28,7 +28,7 @@ require_once 'userOptions.inc'; // Load up our tool system, exit with usage() if options are not fine -$uo = new userOptions( $options, $args ); +$uo = new UserOptions( $options, $args ); $uo->run(); -- To view, visit https://gerrit.wikimedia.org/r/97345 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc9169b238ee3f73021e8f73188c3e5b5f1d36a3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits