Terrrydactyl has uploaded a new change for review.
https://gerrit.wikimedia.org/r/97857
Change subject: Fixed broken tests
......................................................................
Fixed broken tests
Change-Id: I8bb63f0d13695c1af969e59ed0b5daf7ef44988d
---
M tests/fixtures.py
M tests/test_models/test_multi_project_metric_report.py
M wikimetrics/models/validate_cohort.py
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/57/97857/1
diff --git a/tests/fixtures.py b/tests/fixtures.py
index 01be389..dd2bc04 100644
--- a/tests/fixtures.py
+++ b/tests/fixtures.py
@@ -294,7 +294,7 @@
cu = self.session.query(CohortUser) \
.filter(CohortUser.cohort_id == self.cohort.id) \
.one()
- cu.role =
'ALL_ROLES_HAVE_RIGHTS_NOW_SO_CHANGE_TO_UNAUTHORIZED_ROLE_LATER'
+ cu.role = 'UNAUTHORIZED'
self.session.commit()
@nottest
diff --git a/tests/test_models/test_multi_project_metric_report.py
b/tests/test_models/test_multi_project_metric_report.py
index 0d7def6..fdfc28d 100644
--- a/tests/test_models/test_multi_project_metric_report.py
+++ b/tests/test_models/test_multi_project_metric_report.py
@@ -18,7 +18,7 @@
start_date='2013-01-01 00:00:00',
end_date='2013-01-02 00:00:00',
)
- mr = MultiProjectMetricReport(self.cohort, metric, 'enwiki')
+ mr = MultiProjectMetricReport(self.cohort, metric)
result = mr.task.delay(mr).get()
diff --git a/wikimetrics/models/validate_cohort.py
b/wikimetrics/models/validate_cohort.py
index b4b0220..275f46c 100644
--- a/wikimetrics/models/validate_cohort.py
+++ b/wikimetrics/models/validate_cohort.py
@@ -19,7 +19,7 @@
def async_validate(validate_cohort):
task_logger.info('Running Cohort Validation job')
validate_cohort.run()
- return validate_cohort
+ return 'DONE'
class ValidateCohort(object):
--
To view, visit https://gerrit.wikimedia.org/r/97857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bb63f0d13695c1af969e59ed0b5daf7ef44988d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Terrrydactyl <tcho...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
