jenkins-bot has submitted this change and it was merged.
Change subject: Story 1408: Resolve Edit Tutorial A/B Test
......................................................................
Story 1408: Resolve Edit Tutorial A/B Test
Change-Id: I13f55548df57d2524afec9b899617ce216ea4ee6
---
M javascripts/modules/editor/editor.js
M javascripts/modules/tutorials/newbieEditor.js
2 files changed, 13 insertions(+), 26 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/editor.js
b/javascripts/modules/editor/editor.js
index 9634ade..e3133e9 100644
--- a/javascripts/modules/editor/editor.js
+++ b/javascripts/modules/editor/editor.js
@@ -83,13 +83,6 @@
// prevent folding section when clicking Edit
ev.stopPropagation();
} );
-
- // FIXME: remove when edit AB test is done
- if ( M.query.article_action === 'signup-edit' ) {
- $( '.edit-page' ).each( function() {
- $( this ).attr( 'href', $( this ).attr( 'href'
) + '/ctaSignup' );
- } );
- }
}
function initCta() {
diff --git a/javascripts/modules/tutorials/newbieEditor.js
b/javascripts/modules/tutorials/newbieEditor.js
index 65945c8..7edf5fb 100644
--- a/javascripts/modules/tutorials/newbieEditor.js
+++ b/javascripts/modules/tutorials/newbieEditor.js
@@ -14,26 +14,20 @@
// Note if the element was changed since it might not exist.
if ( M.isLoggedIn() && shouldShowEditTutorial && $( target ).length > 0
) {
-
- if ( M.isTestA ) {
- // go straight to the editor if in bucket A
+ editOverlay = new PageActionOverlay( {
+ target: target,
+ className: 'slide active editing',
+ summary: mw.msg(
'mobile-frontend-editor-tutorial-summary', mw.config.get( 'wgTitle' ) ),
+ confirmMsg: mw.msg(
'mobile-frontend-editor-tutorial-confirm' )
+ } );
+ editOverlay.show();
+ $( '#ca-edit' ).on( 'mousedown', $.proxy( editOverlay, 'hide' )
);
+ editOverlay.$( '.actionable' ).on( M.tapEvent( 'click' ),
function() {
+ // Hide the tutorial
+ editOverlay.hide();
+ // Load the editing interface
window.location.href = $( target ).attr( 'href' );
- } else {
- editOverlay = new PageActionOverlay( {
- target: target,
- className: 'slide active editing',
- summary: mw.msg(
'mobile-frontend-editor-tutorial-summary', mw.config.get( 'wgTitle' ) ),
- confirmMsg: mw.msg(
'mobile-frontend-editor-tutorial-confirm' )
- } );
- editOverlay.show();
- $( '#ca-edit' ).on( 'mousedown', $.proxy( editOverlay,
'hide' ) );
- editOverlay.$( '.actionable' ).on( M.tapEvent( 'click'
), function() {
- // Hide the tutorial
- editOverlay.hide();
- // Load the editing interface
- window.location.href = $( target ).attr( 'href'
);
- } );
- }
+ } );
}
}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/97872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13f55548df57d2524afec9b899617ce216ea4ee6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
