TheDJ has submitted this change and it was merged. Change subject: jquery.makeCollapsible: Remove useless debug logging ......................................................................
jquery.makeCollapsible: Remove useless debug logging Custom togglers are nowhere near exciting enough to log the fact that we're looking for them. Added ages ago in r78989 when this script was more hairy. Change-Id: Ieec216e5f203f4d808194733d96dcb3ebe9aaf9b --- M resources/jquery/jquery.makeCollapsible.js 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: TheDJ: Looks good to me, approved diff --git a/resources/jquery/jquery.makeCollapsible.js b/resources/jquery/jquery.makeCollapsible.js index 30be2bd..60c0afc 100644 --- a/resources/jquery/jquery.makeCollapsible.js +++ b/resources/jquery/jquery.makeCollapsible.js @@ -15,8 +15,6 @@ * @license GPL2 <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> */ ( function ( $, mw ) { - var lpx = 'jquery.makeCollapsible> '; - /** * Handler for a click on a collapsible toggler. * @@ -292,17 +290,11 @@ } else { collapsibleId = $collapsible.attr( 'id' ) || ''; if ( collapsibleId.indexOf( 'mw-customcollapsible-' ) === 0 ) { - mw.log( lpx + 'Found custom collapsible: #' + collapsibleId ); $customTogglers = $( '.' + collapsibleId.replace( 'mw-customcollapsible', 'mw-customtoggle' ) ); - - // Double check that there is actually a customtoggle link - if ( !$customTogglers.length ) { - mw.log( lpx + '#' + collapsibleId + ': Missing toggler!' ); - } } } - // Bind the togglers + // Add event handlers to custom togglers or create our own ones if ( $customTogglers && $customTogglers.length ) { actionHandler = function ( e, opts ) { var defaultOpts = {}; -- To view, visit https://gerrit.wikimedia.org/r/97911 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec216e5f203f4d808194733d96dcb3ebe9aaf9b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
