jenkins-bot has submitted this change and it was merged.
Change subject: Don't change single quotes in browser test data
......................................................................
Don't change single quotes in browser test data
It causes problems when doing "eval" with test data and it does not make
any sense to change single quotes withing test data strings to double
quotes
Change-Id: Id1480eaec3411c36efc029eedb6ff2910cfe92ff
---
M selenium_cuc/features/aliases.feature
M selenium_cuc/features/description.feature
M selenium_cuc/features/label.feature
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/selenium_cuc/features/aliases.feature
b/selenium_cuc/features/aliases.feature
index 487ab2f..8931f90 100644
--- a/selenium_cuc/features/aliases.feature
+++ b/selenium_cuc/features/aliases.feature
@@ -194,7 +194,7 @@
| alias | alias_expected |
| 0 | 0 |
| norm a lize me | norm a lize me |
- | <script>$("body").empty();</script> |
<script>$("body").empty();</script> |
+ | <script>$('body').empty();</script> |
<script>$('body').empty();</script> |
@save_aliases
Scenario: Too long input for alias
diff --git a/selenium_cuc/features/description.feature
b/selenium_cuc/features/description.feature
index f420909..b9c1bc1 100644
--- a/selenium_cuc/features/description.feature
+++ b/selenium_cuc/features/description.feature
@@ -84,7 +84,7 @@
| description | expected_description |
| 0 | 0 |
| norm a lize me | norm a lize me |
- | <script>$("body").empty();</script> |
<script>$("body").empty();</script> |
+ | <script>$('body').empty();</script> |
<script>$('body').empty();</script> |
| {{Template:blabla}} | {{Template:blabla}} |
@save_description
diff --git a/selenium_cuc/features/label.feature
b/selenium_cuc/features/label.feature
index 23d8df1..aa4d0f6 100644
--- a/selenium_cuc/features/label.feature
+++ b/selenium_cuc/features/label.feature
@@ -87,7 +87,7 @@
| label | expected_label |
| 0 | 0 |
| norm a lize me | norm a lize me |
- | <script>$("body").empty();</script> |
<script>$("body").empty();</script> |
+ | <script>$('body').empty();</script> |
<script>$('body').empty();</script> |
| {{Template:blabla}} | {{Template:blabla}} |
@save_label
--
To view, visit https://gerrit.wikimedia.org/r/98491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1480eaec3411c36efc029eedb6ff2910cfe92ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
