Hello Stefan.petrea,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/98521
to review the following change.
Change subject: Turn path to filter into variable for tests
......................................................................
Turn path to filter into variable for tests
Change-Id: I4484a77bf31aa3fad0a297c36ac64895c6695568
---
M test.sh
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/webstatscollector
refs/changes/21/98521/1
diff --git a/test.sh b/test.sh
index 8cf9c7a..88bee86 100755
--- a/test.sh
+++ b/test.sh
@@ -1,5 +1,7 @@
#!/bin/bash
-TEST_SPACELESS_LINES=`cat entries-with-urls-with-spaces-2013-02-10.txt |
./filter | perl -MData::Dumper -ne '@f=split(/\s/,$_,4); print if $f[3] =~ /\
/;' | wc -l`
+FILTER="./filter"
+
+TEST_SPACELESS_LINES=`cat entries-with-urls-with-spaces-2013-02-10.txt |
"$FILTER" | perl -MData::Dumper -ne '@f=split(/\s/,$_,4); print if $f[3] =~ /\
/;' | wc -l`
if [ $TEST_SPACELESS_LINES -eq 0 ]; then
@@ -11,7 +13,7 @@
trap "" SIGSEGV
-cat big-entry-1.txt | ./filter >/dev/null 2>/dev/null
+cat big-entry-1.txt | "$FILTER" >/dev/null 2>/dev/null
if [ $? -ne 139 ]; then
echo "Test2: Big fields in filter PASSED";
@@ -19,7 +21,7 @@
echo "Test2: Big fields in filter FAILED";
fi
-TEST_PROJECT_EMPTY=`cat entry-line1.txt | ./filter | wc -l`;
+TEST_PROJECT_EMPTY=`cat entry-line1.txt | "$FILTER" | wc -l`;
if [ $? -ne 139 -a $TEST_PROJECT_EMPTY -eq 0 ]; then
echo "Test3: in->project is empty PASSED";
--
To view, visit https://gerrit.wikimedia.org/r/98521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4484a77bf31aa3fad0a297c36ac64895c6695568
Gerrit-PatchSet: 1
Gerrit-Project: analytics/webstatscollector
Gerrit-Branch: master
Gerrit-Owner: QChris <christ...@quelltextlich.at>
Gerrit-Reviewer: Stefan.petrea <ste...@garage-coding.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
