jenkins-bot has submitted this change and it was merged.
Change subject: Use visibility: hidden; to hide inspectors
......................................................................
Use visibility: hidden; to hide inspectors
Using display: none; on the inspectors WindowSet causes Firefox to
neglect to load CSS in the inspectors' iframes, which means the frame
never initializes and the inspector never opens.
Bug: 57568
Change-Id: Ia1a0ce78754fa1318a7d439abe1f0e2f86420e7a
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index cb5d6cb..0ff9884 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -402,7 +402,9 @@
// Show either inspector or menu
if ( inspector ) {
this.$menu.hide();
- this.inspectors.$element.show();
+ // Use visibility instead of .show()/.hide() so Firefox
won't refuse to load the iframe
+ // inside the inspector (bug 57568)
+ this.inspectors.$element.css( 'visibility', '' );
if ( !repositionOnly ) {
inspector.$element.css( 'opacity', 0 );
}
@@ -413,7 +415,9 @@
inspector.$element.css( 'opacity', 1 );
}, this ), 200 );
} else {
- this.inspectors.$element.hide();
+ // Use visibility instead of .show()/.hide() so Firefox
won't refuse to load the iframe
+ // inside the inspector (bug 57568)
+ this.inspectors.$element.css( 'visibility', 'hidden' );
this.embedded = (
focusedNode &&
focusedNode.$focusable.outerHeight() >
this.$menu.outerHeight() * 2 &&
--
To view, visit https://gerrit.wikimedia.org/r/98569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1a0ce78754fa1318a7d439abe1f0e2f86420e7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
