MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98591
Change subject: jshint config and fixes, FINALLY
......................................................................
jshint config and fixes, FINALLY
Every patch we've submitted up until now has been magically very good
at jshint, because I'm appropriately OCD about it, but now we can actually
point at results.
Also we'll enable voting very soon.
Change-Id: I028fa78a47778c8a4050f6b77623c6bfdc4f9c5b
---
A .jshintignore
A .jshintrc
M resources/multilightbox/lightboxinterface.js
M resources/multilightbox/multilightbox.js
4 files changed, 48 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/91/98591/1
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..cd10695
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1,2 @@
+resources/momentjs
+resources/ext.multimediaViewer.oojs
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..0c288c3
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,44 @@
+{
+ /* Common */
+
+ // Enforcing
+ "camelcase": true,
+ "curly": true,
+ "eqeqeq": true,
+ "immed": true,
+ "latedef": true,
+ "newcap": true,
+ "noarg": true,
+ "noempty": true,
+ "nonew": true,
+ "quotmark": "single",
+ "trailing": true,
+ "undef": true,
+ "unused": true,
+ // Legacy
+ "onevar": true,
+
+ /* Local */
+
+ // Enforcing
+ "bitwise": true,
+ "forin": false,
+ "regexp": false,
+ "strict": false,
+ // Relaxing
+ "laxbreak": true,
+ "smarttabs": true,
+ "multistr": true,
+ // Environment
+ "browser": true,
+ // Legacy
+ "nomen": true,
+
+ "predef": [
+ "mediaWiki",
+ "jQuery",
+ "QUnit",
+ "moment",
+ "lightboxHooks"
+ ]
+}
diff --git a/resources/multilightbox/lightboxinterface.js
b/resources/multilightbox/lightboxinterface.js
index b1baa91..843035c 100644
--- a/resources/multilightbox/lightboxinterface.js
+++ b/resources/multilightbox/lightboxinterface.js
@@ -156,13 +156,7 @@
iface.autoResizeImage();
window.addEventListener( 'resize', function () {
- var result = lightboxHooks.callAll(
'imageResize', iface ),
- isFullScreen = (
-
document.fullscreenElement ||
-
document.mozFullScreenElement ||
-
document.webkitFullScreenElement ||
-
document.msFullScreenElement ),
- $measurement = isFullScreen ?
$( window ) : iface.$image;
+ var result = lightboxHooks.callAll(
'imageResize', iface );
if ( result !== false ) {
iface.autoResizeImage();
diff --git a/resources/multilightbox/multilightbox.js
b/resources/multilightbox/multilightbox.js
index 6bc7cbd..18bdb01 100644
--- a/resources/multilightbox/multilightbox.js
+++ b/resources/multilightbox/multilightbox.js
@@ -14,7 +14,7 @@
this.currentIndex = start || 0;
this.onInterfaceReady = [];
- lightbox.iface = new LightboxInterface();
+ lightbox.iface = new window.LightboxInterface();
lightbox.interfaceReady();
}
--
To view, visit https://gerrit.wikimedia.org/r/98591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I028fa78a47778c8a4050f6b77623c6bfdc4f9c5b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <mtrac...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
