Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/98799
Change subject: Remove unneeded return ...................................................................... Remove unneeded return Return is unnecessary as the last statement in a function with no return value Change-Id: I4c527113d46171a2a845d7a3da94f285659ca758 --- M resources/js/ext.translate.base.js M specials/SpecialManageGroups.php 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/99/98799/1 diff --git a/resources/js/ext.translate.base.js b/resources/js/ext.translate.base.js index e1a3dc9..a46767a 100644 --- a/resources/js/ext.translate.base.js +++ b/resources/js/ext.translate.base.js @@ -107,7 +107,6 @@ if ( group ) { result = group; - return; } } } ); diff --git a/specials/SpecialManageGroups.php b/specials/SpecialManageGroups.php index 93a5ac9..d6213e8 100644 --- a/specials/SpecialManageGroups.php +++ b/specials/SpecialManageGroups.php @@ -174,6 +174,7 @@ * @param string $code * @param string $type * @param array $params + * @param int $limit * @return string HTML */ protected function formatChange( MessageGroup $group, $code, $type, $params, &$limit ) { -- To view, visit https://gerrit.wikimedia.org/r/98799 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c527113d46171a2a845d7a3da94f285659ca758 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits