jenkins-bot has submitted this change and it was merged. Change subject: Return false to stop processing ......................................................................
Return false to stop processing Stumbled upon this issue in static code analysis. Change-Id: I4c527113d46171a2a845d7a3da94f285659ca758 --- M resources/js/ext.translate.base.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.translate.base.js b/resources/js/ext.translate.base.js index e1a3dc9..bda4178 100644 --- a/resources/js/ext.translate.base.js +++ b/resources/js/ext.translate.base.js @@ -99,7 +99,7 @@ $.each( groups, function ( index, group ) { if ( group.id === id ) { result = group; - return; + return false; } if ( group.groups ) { @@ -107,7 +107,7 @@ if ( group ) { result = group; - return; + return false; } } } ); -- To view, visit https://gerrit.wikimedia.org/r/98799 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c527113d46171a2a845d7a3da94f285659ca758 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits