jenkins-bot has submitted this change and it was merged.
Change subject: Fix extra </tr> from DiffOpVisualizer.
......................................................................
Fix extra </tr> from DiffOpVisualizer.
Change-Id: I32191c86e7767684647a7e74ec38a200cd3a73e6
---
M lib/includes/DiffOpValueFormatter.php
M lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php
M lib/tests/phpunit/claim/DiffOpValueFormatterTest.php
3 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Aude: Looks good to me, approved
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/DiffOpValueFormatter.php
b/lib/includes/DiffOpValueFormatter.php
index d427269..89d7d47 100644
--- a/lib/includes/DiffOpValueFormatter.php
+++ b/lib/includes/DiffOpValueFormatter.php
@@ -92,7 +92,6 @@
Html::rawElement( 'ins', array( 'class' =>
'diffchange diffchange-inline' ),
$this->generateValueHtml(
$this->newValues ) ) ) );
$html .= Html::closeElement( 'tr' );
- $html .= Html::closeElement( 'tr' );
return $html;
}
diff --git a/lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php
b/lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php
index a08b2cf..41558f2 100644
--- a/lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php
+++ b/lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php
@@ -103,7 +103,7 @@
'<tr><td class="diff-marker">-</td><td
class="diff-deletedline">'.
'<div><del class="diffchange
diffchange-inline"><span><i>SNAK</i></span></del></div></td>'.
'<td class="diff-marker">+</td><td
class="diff-addedline">'.
- '<div><ins class="diffchange
diffchange-inline"><span><i>SNAK</i></span></ins></div></td></tr></tr>'
+ '<div><ins class="diffchange
diffchange-inline"><span><i>SNAK</i></span></ins></div></td></tr>'
),
//2 +qualifiers
array(
diff --git a/lib/tests/phpunit/claim/DiffOpValueFormatterTest.php
b/lib/tests/phpunit/claim/DiffOpValueFormatterTest.php
index 8e7b203..f02820f 100644
--- a/lib/tests/phpunit/claim/DiffOpValueFormatterTest.php
+++ b/lib/tests/phpunit/claim/DiffOpValueFormatterTest.php
@@ -54,5 +54,4 @@
'@<i>old 1</i>.*<i>old 2</i>.*<i>new
1</i>.*<i>new 2</i>@' ),
);
}
-
}
--
To view, visit https://gerrit.wikimedia.org/r/98816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32191c86e7767684647a7e74ec38a200cd3a73e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
