jenkins-bot has submitted this change and it was merged.

Change subject: Set $wgNoFollowLinks to false iff "Authorized editors only" 
selected
......................................................................


Set $wgNoFollowLinks to false iff "Authorized editors only" selected

Adds a little more whitespace for other configs; let me know if that's
not okay

Bug: 57115
Change-Id: I27775195a1a69cc83c2ea24640e563095591aff7
---
M includes/installer/LocalSettingsGenerator.php
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/installer/LocalSettingsGenerator.php 
b/includes/installer/LocalSettingsGenerator.php
index 56d8353..49fbfe4 100644
--- a/includes/installer/LocalSettingsGenerator.php
+++ b/includes/installer/LocalSettingsGenerator.php
@@ -220,6 +220,17 @@
                                                wfBoolToStr( $perm ) . ";\n";
                                }
                        }
+                       $noFollow = '';
+                       if ( $this->groupPermissions['*']['edit'] === false
+                               && 
$this->groupPermissions['*']['createaccount'] === false
+                               && $this->groupPermissions['*']['read'] !== 
false ) {
+                               $noFollow = "# Set \$wgNoFollowLinks to true if 
you open up your wiki to editing by\n"
+                                       . "# the general public and wish to 
apply nofollow to external links as a\n"
+                                       . "# deterrent to spammers. Nofollow is 
not a comprehensive anti-spam solution\n"
+                                       . "# and open wikis will generally 
require other anti-spam measures; for more\n"
+                                       . "# information, see 
https://www.mediawiki.org/wiki/Manual:Combating_spam\n";
+                                       . "\$wgNoFollowLinks = false;";
+                       }
                }
 
                $wgServerSetting = "";
@@ -353,6 +364,7 @@
 # Path to the GNU diff3 utility. Used for conflict resolution.
 \$wgDiff3 = \"{$this->values['wgDiff3']}\";
 
-{$groupRights}";
+{$groupRights}
+{$noFollow}";
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/95755
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27775195a1a69cc83c2ea24640e563095591aff7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: leucosticte <nathanlarson3...@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Waldir <wal...@email.com>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to