Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/98974
Change subject: Set saner default for parameters of LogEventsList::showOptions()
......................................................................
Set saner default for parameters of LogEventsList::showOptions()
Also cast input for Xml::dateMenu().
Change-Id: I28f9184626b01cce4a8080ba3337af0b3f941484
---
M includes/logging/LogEventsList.php
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/98974/1
diff --git a/includes/logging/LogEventsList.php
b/includes/logging/LogEventsList.php
index 8225bec..31e6bfd 100644
--- a/includes/logging/LogEventsList.php
+++ b/includes/logging/LogEventsList.php
@@ -99,8 +99,9 @@
* @param array $filter
* @param string $tagFilter Tag to select by default
*/
- public function showOptions( $types = array(), $user = '', $page = '',
$pattern = '', $year = '',
- $month = '', $filter = null, $tagFilter = '' ) {
+ public function showOptions( $types = array(), $user = '', $page = '',
$pattern = '', $year = 0,
+ $month = 0, $filter = null, $tagFilter = ''
+ ) {
global $wgScript, $wgMiserMode;
$title = SpecialPage::getTitleFor( 'Log' );
@@ -124,7 +125,7 @@
}
// date menu
- $html .= Xml::tags( 'p', null, Xml::dateMenu( $year, $month ) );
+ $html .= Xml::tags( 'p', null, Xml::dateMenu( (int)$year,
(int)$month ) );
// Tag filter
if ( $tagSelector ) {
--
To view, visit https://gerrit.wikimedia.org/r/98974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28f9184626b01cce4a8080ba3337af0b3f941484
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
