jenkins-bot has submitted this change and it was merged.

Change subject: Some comments for replacing core mediawiki.ui
......................................................................


Some comments for replacing core mediawiki.ui

This LESS code can be the basis of updated mediawiki.ui in core (bug
54360), but needs some changes and additions.

Change-Id: I4bb7b47f41e2a8620f61aa495889adee5b67b7e4
---
M modules/mediawiki.ui/styles/agora-override-buttons.less
M modules/mediawiki.ui/styles/mixins/buttons.less
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Bsitu: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/mediawiki.ui/styles/agora-override-buttons.less 
b/modules/mediawiki.ui/styles/agora-override-buttons.less
index 41a4079..0c1114d 100644
--- a/modules/mediawiki.ui/styles/agora-override-buttons.less
+++ b/modules/mediawiki.ui/styles/agora-override-buttons.less
@@ -56,6 +56,8 @@
                }
        }
 
+       // TODO: mw-ui-progressive (blue) for intermediate steps from Agora 
specs.
+
        &.mw-ui-destructive {
                .buttonColors(
                        // normal
diff --git a/modules/mediawiki.ui/styles/mixins/buttons.less 
b/modules/mediawiki.ui/styles/mixins/buttons.less
index 0072940..cab29ea 100644
--- a/modules/mediawiki.ui/styles/mixins/buttons.less
+++ b/modules/mediawiki.ui/styles/mixins/buttons.less
@@ -49,7 +49,8 @@
        }
 
 
-       // text-only, borderless text-button
+       // text-only, borderless text-button for secondary or "quiet" actions.
+       // TODO Rename this mw-ui-quiet
        &.mw-ui-text {
                border: 1px solid transparent;
                box-shadow: 0px 0px 0px 0px transparent;

-- 
To view, visit https://gerrit.wikimedia.org/r/98963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4bb7b47f41e2a8620f61aa495889adee5b67b7e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: Bsitu <bs...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to