[MediaWiki-commits] [Gerrit] Updating with kafka.socket.send.buffer.bytes configuration p... - change (operations...varnishkafka)

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99160


Change subject: Updating with kafka.socket.send.buffer.bytes configuration 
parameter
......................................................................

Updating with kafka.socket.send.buffer.bytes configuration parameter

Change-Id: If6254de9d6c810adbe80a481ae09bce923a11054
---
M manifests/defaults.pp
M manifests/init.pp
M templates/varnishkafka.conf.erb
3 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/varnishkafka 
refs/changes/60/99160/1

diff --git a/manifests/defaults.pp b/manifests/defaults.pp
index 449662f..b14debd 100644
--- a/manifests/defaults.pp
+++ b/manifests/defaults.pp
@@ -18,6 +18,7 @@
     $topic_request_required_acks    = 1
     $topic_message_timeout_ms       = 300000
     $topic_request_timeout_ms       = 5000
+    $socket_send_buffer_bytes       = 0
     $compression_codec              = 'none'
 
     $varnish_opts                   = {
diff --git a/manifests/init.pp b/manifests/init.pp
index 21a2087..6a4ca64 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -32,6 +32,8 @@
 #                                     Default: 300000
 # $topic_request_timeout_ms         - Ack timeout of the produce request.
 #                                     Default: 5000
+# $socket_send_buffer_bytes         - SO_SNDBUFF Socket send buffer size. 
System default is used if 0.
+#                                     Default: 0
 # $compression_codec                - Compression codec to use when sending 
batched messages to
 #                                     Kafka.  Valid values are 'none', 'gzip', 
and 'snappy'.
 #                                     Default: none
@@ -78,6 +80,7 @@
     $topic_request_required_acks    = 
$varnishkafka::defaults::topic_request_required_acks,
     $topic_message_timeout_ms       = 
$varnishkafka::defaults::topic_message_timeout_ms,
     $topic_request_timeout_ms       = 
$varnishkafka::defaults::topic_request_timeout_ms,
+    $socket_send_buffer_bytes       = 
$varnishkafka::defaults::socket_send_buffer_bytes,
     $compression_codec              = 
$varnishkafka::defaults::compression_codec,
 
     $varnish_opts                   = $varnishkafka::defaults::varnish_opts,
diff --git a/templates/varnishkafka.conf.erb b/templates/varnishkafka.conf.erb
index 6141945..67d8449 100644
--- a/templates/varnishkafka.conf.erb
+++ b/templates/varnishkafka.conf.erb
@@ -269,4 +269,7 @@
 
 # The ack timeout of the producer request in milliseconds
 kafka.topic.request.timeout.ms = <%= @topic_request_timeout_ms %>
+
+# SO_SNDBUFF Socket send buffer size. System default is used if 0.
+kafka.socket.send.buffer.bytes = <%= @socket_send_buffer_bytes %>
 <% end -%>

-- 
To view, visit https://gerrit.wikimedia.org/r/99160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If6254de9d6c810adbe80a481ae09bce923a11054
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/varnishkafka
Gerrit-Branch: master
Gerrit-Owner: Ottomata <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits