Siebrand has uploaded a new change for review.
Change subject: Moved most database interaction to CentralNoticeDB.
......................................................................
Moved most database interaction to CentralNoticeDB.
* Use CentralNoticeDB as a proper object, removing static methods. Changed the
interface of some methods a bit, for example for passing a user object or
allowing error information to go back up.
* Removed redundant showError() in SpecialNoticeTemplate.php.
Change-Id: I89b1cf0899e3a446d7936f35dc3727a30b0c96c3
Todo: I don't have experience with tests yet, and I don't know how to create
user object to feed into self::$centralNoticeDB->addCampaign and
self::$centralNoticeDB->removeCampaign in tests/CentralNoticeTest.php.
Please provide help in comments.
---
M CentralNotice.db.php
M CentralNoticePager.php
M api/ApiCentralNoticeAllocations.php
M special/SpecialBannerAllocation.php
M special/SpecialBannerListLoader.php
M special/SpecialBannerLoader.php
M special/SpecialCentralNotice.php
M special/SpecialNoticeTemplate.php
M tests/CentralNoticeTest.php
9 files changed, 688 insertions(+), 692 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/44/22944/1
--
To view, visit https://gerrit.wikimedia.org/r/22944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89b1cf0899e3a446d7936f35dc3727a30b0c96c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
