Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/99673
Change subject: Add setting to disable displaying parser function errors ...................................................................... Add setting to disable displaying parser function errors this is done with css, so can be displayed for debugging, or customized in other ways. default is to show errors. Change-Id: I3b4edd193e29a2db88185ef5cbf989dc575dbe49 --- M client/WikibaseClient.hooks.php M client/config/WikibaseClient.default.php M client/resources/Resources.php A client/resources/wikibase.client.propertyparsererror.css 4 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/73/99673/1 diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index f47cb8e..ee90ca4 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -517,11 +517,16 @@ if ( !empty( $errors ) ) { foreach ( $errors as $errorMessage ) { $out->addWikiText( - '<p class="error">' . $errorMessage . '</p>' + '<p class="error wikibase-property-parser-error">' . $errorMessage . '</p>' ); } } + // todo maybe allow this to vary based on anon / logged in userss + if ( Settings::get( 'hideParserFunctionErrors' ) ) { + $out->addModules( 'wikibase.client.propertyparsererror.css' ); + } + return true; } diff --git a/client/config/WikibaseClient.default.php b/client/config/WikibaseClient.default.php index 023b3c3..2c02ec4 100644 --- a/client/config/WikibaseClient.default.php +++ b/client/config/WikibaseClient.default.php @@ -39,6 +39,7 @@ 'allowDataTransclusion' => true, 'enableSiteLinkWidget' => true, 'propagateChangesToRepo' => true, + 'hideParserFunctionErrors' => false, // allows hiding parser function errors with css /** * @todo this is a bit wikimedia-specific and need to find a better place for this stuff, diff --git a/client/resources/Resources.php b/client/resources/Resources.php index d3d3e52..f27005c 100644 --- a/client/resources/Resources.php +++ b/client/resources/Resources.php @@ -25,6 +25,9 @@ 'wikibase.client.changeslist.css' => $moduleTemplate + array( 'styles' => 'wikibase.client.changeslist.css' ), + 'wikibase.client.propertyparsererror.css' => $moduleTemplate + array( + 'styles' => 'wikibase.client.propertyparsererror.css' + ), 'wikibase.client.linkitem.init' => $moduleTemplate + array( 'scripts' => array( 'wikibase.client.linkitem.init.js' diff --git a/client/resources/wikibase.client.propertyparsererror.css b/client/resources/wikibase.client.propertyparsererror.css new file mode 100644 index 0000000..59b2baf --- /dev/null +++ b/client/resources/wikibase.client.propertyparsererror.css @@ -0,0 +1,6 @@ +/* CSS with the sole purpose to hide property parser + function errors, which can be controlled with + $wgWBClientSettings['hidePropertyParserError'] */ +.wikibase-property-parser-error { + display: none; +} -- To view, visit https://gerrit.wikimedia.org/r/99673 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b4edd193e29a2db88185ef5cbf989dc575dbe49 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.23-wmf5 Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits