Mwalker has submitted this change and it was merged.
Change subject: Revert "Log an obnoxious amount of debug data via the form
chooser." This served its purpose, and we don't need it anymore.
......................................................................
Revert "Log an obnoxious amount of debug data via the form chooser."
This served its purpose, and we don't need it anymore.
This reverts commit a204940200b24d1f8a007e730517f459959ec2d1.
Change-Id: Ib1f619e6600df65f39ac891dbf8f0d057f6ff04a
---
M special/GatewayFormChooser.php
1 file changed, 0 insertions(+), 29 deletions(-)
Approvals:
Mwalker: Looks good to me, approved
diff --git a/special/GatewayFormChooser.php b/special/GatewayFormChooser.php
index 82fe55d..aae8e5b 100644
--- a/special/GatewayFormChooser.php
+++ b/special/GatewayFormChooser.php
@@ -66,17 +66,6 @@
$redirectURL = self::buildPaymentsFormURL( $form, $params );
- $debug_mess = __FUNCTION__;
- $ctid = @$GET['contribution_tracking_id'];
- if ( !is_null( $ctid ) ) {
- $debug_mess .= " $ctid";
- }
- $debug_mess .= " GatewayFormChooser built URL '$redirectURL'
for country '$country', currency '$currency', method '$paymentMethod',
submethod '$paymentSubMethod', recurring: '$recurring', gateway '$gateway'.";
- GatewayAdapter::log( $debug_mess, LOG_DEBUG );
-
- error_log( $debug_mess );
-
-
// Perform the redirection
$this->getOutput()->redirect( $redirectURL );
}
@@ -281,15 +270,6 @@
$forms = self::getAllValidForms( $country, $currency,
$payment_method, $payment_submethod, $recurring, $gateway );
$form = self::pickOneForm( $forms, $currency, $country );
- //done playing.
- $debug_mess = __FUNCTION__;
- $ctid = @$GET['contribution_tracking_id'];
- if ( !is_null( $ctid ) ) {
- $debug_mess .= " $ctid";
- }
- $debug_mess .= " Selected '$form' for country '$country',
currency '$currency', method '$payment_method', submethod '$payment_submethod',
recurring: '$recurring', gateway '$gateway'.";
- GatewayAdapter::log( $debug_mess, LOG_DEBUG );
-
//TODO:
//This here, would be an excellent place to default to
//"sorry, we don't support that thing you're trying to do."
@@ -358,15 +338,6 @@
if ( is_array( $forms ) && array_key_exists( $ffname, $forms )
) {
return true;
}
-
- $debug_mess = __FUNCTION__;
- $ctid = @$GET['contribution_tracking_id'];
- if ( !is_null( $ctid ) ) {
- $debug_mess .= " $ctid";
- }
- $debug_mess .= " Form '$ffname' found to be invalid for country
'$country', currency '$currency', method '$payment_method', submethod
'$payment_submethod', recurring: '$recurring', gateway '$gateway'.";
- GatewayAdapter::log( $debug_mess, LOG_DEBUG );
-
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/100118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f619e6600df65f39ac891dbf8f0d057f6ff04a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <kh...@wikimedia.org>
Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
