[MediaWiki-commits] [Gerrit] Ensure entityselector's suggestion list is assigned absolute... - change (mediawiki...Wikibase)

[Tobias Gritschacher (Code Review)]

Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100575


Change subject: Ensure entityselector's suggestion list is assigned absolute 
position
......................................................................

Ensure entityselector's suggestion list is assigned absolute position

Proper list offset added additionally.

Change-Id: Iec37723028fbd687ab402daf9eb5e8923244d228
---
M 
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entityselector.css
M repo/resources/wikibase.ui.entitysearch.js
2 files changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/75/100575/1

diff --git 
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entityselector.css
 
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entityselector.css
index e3530a6..23d04d8 100644
--- 
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entityselector.css
+++ 
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entityselector.css
@@ -7,6 +7,7 @@
 
 .ui-entityselector-list {
        padding: 0;
+       position: absolute;
        overflow-x: hidden;
 }
 
diff --git a/repo/resources/wikibase.ui.entitysearch.js 
b/repo/resources/wikibase.ui.entitysearch.js
index 5fc2367..f05cb18 100644
--- a/repo/resources/wikibase.ui.entitysearch.js
+++ b/repo/resources/wikibase.ui.entitysearch.js
@@ -64,7 +64,12 @@
                                        $form.submit();
                                },
                                cssClass: 'wb-entitysearch-suggestions'
-                       }
+                       },
+                       position: $.extend(
+                               {},
+                               
$.wikibase.entityselector.prototype.options.position,
+                               { offset: '-1 2' }
+                       )
                } )
                .on( 'entityselectoropen', function( event ) {
                        updateSuggestionSpecial();

-- 
To view, visit https://gerrit.wikimedia.org/r/100575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec37723028fbd687ab402daf9eb5e8923244d228
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.23-wmf6
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits