Ori.livneh has submitted this change and it was merged.
Change subject: Duplicate client-side latency measurements from eswiki to
special bin
......................................................................
Duplicate client-side latency measurements from eswiki to special bin
This patch will create a discrete StatsD stat group for Navigation Timing
measurements from eswiki. I plan to temporarily disable module storage on
eswiki to assess its impact, so having separate graphs will be convenient.
Change-Id: I344f180c29a73cd05d33a0f5be03e9aa0fc3c0dd
---
M files/graphite/modules/navtiming.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/files/graphite/modules/navtiming.py
b/files/graphite/modules/navtiming.py
index 255519e..9cc15b5 100644
--- a/files/graphite/modules/navtiming.py
+++ b/files/graphite/modules/navtiming.py
@@ -58,14 +58,14 @@
if 'loadEventEnd' in event and 'domInteractive' in event:
event['pageSpeed'] = (
event['loadEventEnd'] - event['domInteractive'])
- if 'loadEventEnd' in event and 'navigationStart' in event:
- event['totalPageLoadTime'] = (
- event['loadEventEnd'] - event['navigationStart'])
+ if 'loadEventEnd' in event:
+ event['totalPageLoadTime'] = event['loadEventEnd']
site = 'mobile' if 'mobileMode' in event else 'desktop'
auth = 'anonymous' if event.get('isAnon') else 'authenticated'
bits_cache = meta.get('recvFrom', '').split('.')[0]
+ wiki = meta.get('wiki', '')
for metric in metrics:
value = event.get(metric, 0)
@@ -76,3 +76,6 @@
sock.sendto(stat.encode('utf-8'), addr)
stat = 'browser.%s.%s:%s|ms' % (metric, bits_cache, value)
sock.sendto(stat.encode('utf-8'), addr)
+ if wiki == 'eswiki':
+ stat = 'browser.%s.%s.%s:%s|ms' % (wiki, metric, site, value)
+ sock.sendto(stat.encode('utf-8'), addr)
--
To view, visit https://gerrit.wikimedia.org/r/100736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I344f180c29a73cd05d33a0f5be03e9aa0fc3c0dd
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
