Henning Snater has submitted this change and it was merged. Change subject: (39581) Special:CreateItem first iteration ......................................................................
(39581) Special:CreateItem first iteration - patchset 10: ready for review; added selenium test; - patchset 11: added more tests; removed old create-new-item-test; removed hardcoded language; - patchset 12: adjusted seleniumtests to use new CreateItem SpecialPage - patchset 13: fixed editonoff test - patchset 14: added flags to attemptSave(); use showErrorPage instead of throwing an exception; - patchset 15: added some css - patchset 16: added $user to editEntity; changed msg; - patchset 17: added some more doxygen documentation - patchset 18: fixed selenium tests Change-Id: I715ac9fb1887eb81651249058df5b782ebb5e777 --- M repo/Wikibase.i18n.php M repo/includes/specials/SpecialCreateItem.php M repo/resources/Resources.php A repo/resources/wikibase.special/wikibase.special.css M repo/tests/selenium/item/editonoff_spec.rb D repo/tests/selenium/item/new_item_spec.rb A repo/tests/selenium/special/create_item_spec.rb M selenium/Rakefile A selenium/lib/pages/create_item_page.rb M selenium/lib/pages/item_page.rb 10 files changed, 239 insertions(+), 117 deletions(-) Approvals: John Erling Blad: Looks good to me, but someone else must approve Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22706 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715ac9fb1887eb81651249058df5b782ebb5e777 Gerrit-PatchSet: 18 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig <jens.oh...@wikimedia.de> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
