Jhall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/101040
Change subject: [Browser test] Updates to use new Insert menu
......................................................................
[Browser test] Updates to use new Insert menu
"Insert" menu replaces "More" menu for
accessing some advanced markup features.
Change-Id: I57635b54f3a5b2b72f754747bdb836fe1bfda5ec
---
M modules/ve-mw/test/browser/features/references.feature
M modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
M modules/ve-mw/test/browser/features/step_definitions/references_steps.rb
M modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb
M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
5 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/40/101040/1
diff --git a/modules/ve-mw/test/browser/features/references.feature
b/modules/ve-mw/test/browser/features/references.feature
index 5b6c074..e067a52 100644
--- a/modules/ve-mw/test/browser/features/references.feature
+++ b/modules/ve-mw/test/browser/features/references.feature
@@ -9,4 +9,4 @@
And I can see the References User Interface
And I enter THIS IS CONTENT into Content box
And I click Insert reference
- Then link to More menu should be visible
+ Then link to Insert menu should be visible
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
index be61421..14cb37c 100644
---
a/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
+++
b/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
@@ -1,6 +1,6 @@
When(/^I click Media$/) do
on(VisualEditorPage) do |page|
- page.more_menu_element.when_present.click
+ page.insert_menu_element.when_present.click
page.ve_media_menu_element.when_present.click
end
end
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/references_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/references_steps.rb
index d99dbc5..867f378 100644
--- a/modules/ve-mw/test/browser/features/step_definitions/references_steps.rb
+++ b/modules/ve-mw/test/browser/features/step_definitions/references_steps.rb
@@ -20,7 +20,7 @@
When(/^I click Reference$/) do
on(VisualEditorPage) do |page|
- page.more_menu_element.when_present.click
+ page.insert_menu_element.when_present.click
page.ve_references_element.when_present.click
end
end
@@ -36,6 +36,6 @@
on(VisualEditorPage).insert_reference_element.should be_visible
end
-Then(/^link to More menu should be visible$/) do
- on(VisualEditorPage).more_menu_element.should be_visible
+Then(/^link to Insert menu should be visible$/) do
+ on(VisualEditorPage).insert_menu_element.should be_visible
end
\ No newline at end of file
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb
index 4cfd7fc..8142c44 100644
--- a/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb
+++ b/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb
@@ -21,7 +21,7 @@
When(/^I click Transclusion$/) do
on(VisualEditorPage) do |page|
- page.more_menu_element.when_present.click
+ page.insert_menu_element.when_present.click
page.transclusion_element.when_present.click
end
end
diff --git
a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
index 2ecf164..856f2ac 100644
--- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
@@ -13,12 +13,12 @@
span(:heading, text: 'Heading')
span(:increase_indentation, class: 'oo-ui-widget oo-ui-tool
oo-ui-tool-name-indent oo-ui-widget-disabled')
a(:increase_indentation_on, title: /Increase indentation/)
+ span(:insert_menu, text: 'Insert')
div(:insert_references, class: 'oo-ui-window-title')
span(:internal_linksuggestion, text: 'Main Page')
div(:ip_warning, class: 've-ui-mwNoticesPopupTool-item')
span(:linksuggestion, text: 'http://www.example.com')
span(:looks_good, class: 'oo-ui-labeledElement-label', text: 'Looks good to
me')
- span(:more_menu, text: 'Insert')
span(:newpage_linksuggestion, text: 'DoesNotExist')
div(:page_text, id: 'mw-content-text')
span(:page_title, text: 'Page title')
--
To view, visit https://gerrit.wikimedia.org/r/101040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57635b54f3a5b2b72f754747bdb836fe1bfda5ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jhall <jh...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
