Daniel Werner has submitted this change and it was merged. Change subject: Fixed 4 bugs in TestSites::insertIntoDb() ......................................................................
Fixed 4 bugs in TestSites::insertIntoDb() 1) use plain table name, Database::delete already deals with the prefix. 2) clear site_identifiers table in addition to sites table. 3) re-cache Sites singleton after updating the DB. 4) don't assign global IDs explicitely. Change-Id: I471cdb9ac46a96990f35dac7f9a20847957cd0ab --- M lib/tests/phpunit/site/SiteListTest.php M lib/tests/phpunit/site/TestSites.php 2 files changed, 20 insertions(+), 10 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/23061 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I471cdb9ac46a96990f35dac7f9a20847957cd0ab Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
