jenkins-bot has submitted this change and it was merged.
Change subject: Enables retrieving broken redirects from special page and try
to fix them
......................................................................
Enables retrieving broken redirects from special page and try to fix them
There is a new behavior for broken redirects. They are no longer
just deleted but bot tries to fix broken redirects:
- Now we can read broken redirects from special page
- First check we can solve the problem. We look at the deleted
target page and check whether that has been moved. If yes, we
have found the new target and we repair the broken redirect with
the already existing message 'redirect-fix-broken-moved'.
- Otherwise we delete the broken redirect if the new -delete option
is given and the bot has sysop rights. Without sysop rights we
place a speedy deletion template at the page if we have some.
- Documentation updated.
Change-Id: I5a0f50d4145f1510bd2a430d3f5db0dbb081ef7c
---
M scripts/redirect.py
1 file changed, 88 insertions(+), 12 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/redirect.py b/scripts/redirect.py
index 8ece506..0487f2a 100755
--- a/scripts/redirect.py
+++ b/scripts/redirect.py
@@ -12,7 +12,11 @@
where action can be one of these:
double Fix redirects which point to other redirects
-broken Delete redirects where targets don\'t exist. Requires adminship.
+broken Tries to fix broken redirect to the last moved target of the
+ destination page. If this fails and -delete option is given
+ it deletes redirects where targets don't exist if bot has
+ admin rights otherwise it marks the page with a speedy deletion
+ template if available.
both Both of the above.
and arguments can be:
@@ -44,8 +48,12 @@
-until:title The possible last page title in each namespace. Page needs not
exist.
+-step:n The number of entries retrieved at oncevia API
+
-total:n The maximum count of redirects to work upon. If omitted, there
is no limit.
+
+-delete Enables deletion of broken redirects.
-always Don't prompt you for each replacement.
@@ -53,7 +61,7 @@
#
# (C) Daniel Herding, 2004.
# (C) Purodha Blissenbach, 2009.
-# (C) xqt, 2009-2012
+# (C) xqt, 2009-2013
# (C) Pywikibot team, 2004-2013
#
# Distributed under the terms of the MIT license.
@@ -261,6 +269,12 @@
count += 1
if count >= self.api_number:
break
+ elif not self.xmlFilename:
+ # retrieve information from broken redirect special page
+ pywikibot.output(u'Retrieving special page...')
+ for redir_name in self.site.broken_redirects():
+ yield redir_name.title()
+
# TODO: add XML dump support
## elif self.xmlFilename == None:
## # retrieve information from the live wiki's maintenance page
@@ -356,12 +370,14 @@
class RedirectRobot:
- def __init__(self, action, generator, always=False, number=None):
+ def __init__(self, action, generator, always=False, number=None,
+ delete=False):
self.site = pywikibot.getSite()
self.action = action
self.generator = generator
self.always = always
self.number = number
+ self.delete = delete
self.exiting = False
def prompt(self, question):
@@ -380,13 +396,21 @@
def delete_broken_redirects(self):
# get reason for deletion text
- reason = i18n.twtranslate(self.site, 'redirect-remove-broken')
for redir_name in self.generator.retrieve_broken_redirects():
- self.delete_1_broken_redirect(redir_name, reason)
+ self.delete_1_broken_redirect(redir_name)
if self.exiting:
break
- def delete_1_broken_redirect(self, redir_name, reason):
+ def moved_page(self, source):
+ gen = iter(self.site.logevents(logtype='move', page=source, total=1))
+ try:
+ lastmove = next(gen)
+ except StopIteration:
+ return None
+ else:
+ return lastmove.new_title()
+
+ def delete_1_broken_redirect(self, redir_name):
redir_page = pywikibot.Page(self.site, redir_name)
# Show the title of the page we're working on.
# Highlight the title in purple.
@@ -401,11 +425,57 @@
else:
try:
targetPage.get()
+ except pywikibot.BadTitle:
+ pywikibot.warning(
+ u'Redirect target %s is not a valid page title.'
+ % str(e)[10:])
+ pass
except pywikibot.NoPage:
- if self.prompt(u'Redirect target %s does not exist. '
- u'Do you want to delete %s?'
- % (targetPage.title(asLink=True),
- redir_page.title(asLink=True))):
+ movedTarget = self.moved_page(targetPage)
+ if movedTarget:
+ if not movedTarget.exists():
+ ### FIXME: Test to another move
+ pywikibot.output(u'Target page %s does not exist'
+ % (movedTarget))
+ elif redir_name == movedTarget.title():
+ pywikibot.output(u'Target page forms a redirect loop')
+ else:
+ pywikibot.output(u'%s has been moved to %s'
+ % (redir_page, movedTarget))
+ reason = i18n.twtranslate(self.site,
+ 'redirect-fix-broken-moved',
+ {'to': movedTarget.title(
+ asLink=True)})
+ content = redir_page.get(get_redirect=True)
+ text = self.site.redirectRegex().sub(
+ '#%s %s' % (self.site.redirect(),
+ movedTarget.title(asLink=True,
+ textlink=True)),
+ content)
+ pywikibot.showDiff(content, text)
+ pywikibot.output(u'Summary - %s' % reason)
+ if self.prompt(
+ u'Redirect target %s has been moved to %s.\n'
+ u'Do you want to fix %s?'
+ % (targetPage, movedTarget, redir_page)):
+ try:
+ redir_page.put(text, reason)
+ except pywikibot.NoUsername:
+ pywikibot.output(u"Page [[%s]] not saved; "
+ u"sysop privileges required."
+ % redir.title())
+ pass
+ except pywikibot.LockedPage:
+ pywikibot.output(u'%s is locked.'
+ % redir.title())
+ pass
+ elif self.delete and self.prompt(
+ u'Redirect target %s does not exist.\n'
+ u'Do you want to delete %s?'
+ % (targetPage.title(asLink=True),
+ redir_page.title(asLink=True))):
+ reason = i18n.twtranslate(self.site,
+ 'redirect-remove-broken')
try:
redir_page.delete(reason, prompt=False)
except pywikibot.NoUsername:
@@ -413,7 +483,7 @@
targetPage.site.lang,
'redirect-broken-redirect-template') and
i18n.twhas_key(targetPage.site.lang,
- 'redirect-remove-broken')) or \
+ 'redirect-remove-broken')) or
targetPage.site.lang == '-'):
pywikibot.output(u"No sysop in user-config.py, "
u"put page to speedy deletion.")
@@ -425,6 +495,9 @@
'redirect-broken-redirect-template'
) + "\n" + content
redir_page.put(content, reason)
+ else:
+ pywikibot.output(
+ u'No speedy deletion template availlable')
except pywikibot.IsRedirectPage:
pywikibot.output(u"Redirect target %s is also a redirect! "
u"Won't delete anything."
@@ -663,6 +736,7 @@
number = None
step = None
always = False
+ delete = False
for arg in pywikibot.handleArgs(*args):
if arg == 'double' or arg == 'do':
action = 'double'
@@ -706,6 +780,8 @@
step = int(arg[6:])
elif arg == '-always':
always = True
+ elif arg == '-delete':
+ delete = True
else:
pywikibot.output(u'Unknown argument: %s' % arg)
@@ -718,7 +794,7 @@
else:
gen = RedirectGenerator(xmlFilename, namespaces, offset, moved_pages,
fullscan, start, until, number, step)
- bot = RedirectRobot(action, gen, always, number)
+ bot = RedirectRobot(action, gen, always, number, delete)
bot.run()
if __name__ == '__main__':
--
To view, visit https://gerrit.wikimedia.org/r/102151
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a0f50d4145f1510bd2a430d3f5db0dbb081ef7c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
