Ottomata has submitted this change and it was merged.

Change subject: Updating varnishkafka ganglia view with per_second metrics
......................................................................


Updating varnishkafka ganglia view with per_second metrics

Change-Id: I7b79008c69115d6fedb960696ed810615d7a3989
---
M manifests/misc/monitoring.pp
1 file changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/manifests/misc/monitoring.pp b/manifests/misc/monitoring.pp
index bb617c1..a2c5ec6 100644
--- a/manifests/misc/monitoring.pp
+++ b/manifests/misc/monitoring.pp
@@ -256,16 +256,24 @@
     ganglia::view { 'varnishkafka':
         ensure => $ensure,
         graphs => [
-            # delivery report errors
+            # delivery report errors rate
+            {
+                'host_regex'   => $varnishkafka_host_regex,
+                'metric_regex' => 'kafka.varnishkafka\.kafka_drerr.per_second',
+                'type'         => 'stack',
+            },
+            # delivery report errors.
+            # drerr is important, but seems to happen in bursts.
+            # let's show the total drerr in the view as well.
             {
                 'host_regex'   => $varnishkafka_host_regex,
                 'metric_regex' => 'kafka.varnishkafka\.kafka_drerr',
                 'type'         => 'stack',
             },
-            # round trip time average
+            # round trip time average rate
             {
                 'host_regex'   => $varnishkafka_host_regex,
-                'metric_regex' => 'kafka.rdkafka.brokers..+\.rtt\.avg',
+                'metric_regex' => 
'kafka.rdkafka.brokers..+\.rtt\.avg.per_second',
                 'type'         => 'line',
             },
 
@@ -296,16 +304,16 @@
                 'type'         => 'stack',
             },
 
-            # transaction bytes
+            # transaction bytes rate
             {
                 'host_regex'   => $varnishkafka_host_regex,
-                'metric_regex' => 'kafka.rdkafka.topics..+\.txbytes',
+                'metric_regex' => 
'kafka.rdkafka.topics..+\.txbytes.per_second',
                 'type'         => 'stack',
             },
-            # transaction messages
+            # transaction messages rate
             {
                 'host_regex'   => $varnishkafka_host_regex,
-                'metric_regex' => 'kafka.rdkafka.topics..+\.txmsgs',
+                'metric_regex' => 'kafka.rdkafka.topics..+\.txmsgs.per_second',
                 'type'         => 'stack',
             },
         ],

-- 
To view, visit https://gerrit.wikimedia.org/r/102199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b79008c69115d6fedb960696ed810615d7a3989
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to