Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix interface documentation for EntityIdParser
......................................................................
Fix interface documentation for EntityIdParser
Change-Id: Ie32b9d1e9c60101d21b447285c39c2af67eea9b8
---
M DataModel/Entity/EntityIdParser.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jeroen De Dauw: Verified; Looks good to me, approved
diff --git a/DataModel/Entity/EntityIdParser.php
b/DataModel/Entity/EntityIdParser.php
index e1988d4..cfb3b80 100644
--- a/DataModel/Entity/EntityIdParser.php
+++ b/DataModel/Entity/EntityIdParser.php
@@ -3,7 +3,7 @@
namespace Wikibase\DataModel\Entity;
/**
- * Interface for objects that can parse EntityIds
+ * Interface for objects that can parse strings into EntityIds
*
* @since 0.5
*
@@ -17,7 +17,8 @@
*
* @param string $entityId
*
- * @return mixed
+ * @return EntityId
+ * @throws EntityIdParsingException
*/
public function parse( $entityId );
--
To view, visit https://gerrit.wikimedia.org/r/102296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie32b9d1e9c60101d21b447285c39c2af67eea9b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
