jenkins-bot has submitted this change and it was merged. Change subject: [browser test] Prefer string interpolation instead of string concatenation ......................................................................
[browser test] Prefer string interpolation instead of string concatenation Following Ruby coding convention[1]. Also fixes "no implicit conversion of nil into String (TypeError)" error. 1: https://github.com/styleguide/ruby Change-Id: I3bcf9ba08476117921de7d5a242f3726d8b05efb --- M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jhall: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index 856f2ac..b43ecd9 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -2,7 +2,7 @@ include PageObject include URL - page_url URL.url("User:" + ENV["MEDIAWIKI_USER"]) + page_url URL.url("User:#{ENV['MEDIAWIKI_USER']}") div(:container_disabled, class: 'oo-ui-widget oo-ui-widget-disabled oo-ui-flaggableElement-constructive oo-ui-pushButtonWidget') div(:content, class: 've-ce-documentNode ve-ce-branchNode') -- To view, visit https://gerrit.wikimedia.org/r/102456 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bcf9ba08476117921de7d5a242f3726d8b05efb Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Jhall <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
