Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/102573
Change subject: Adding auto_create_topics_enable parameter
......................................................................
Adding auto_create_topics_enable parameter
Also adding documentation about heap_opts
Change-Id: Iee8f0117e9d5c170a747729e0e75471948366d09
---
M manifests/defaults.pp
M manifests/server.pp
M templates/server.properties.erb
3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/kafka
refs/changes/73/102573/1
diff --git a/manifests/defaults.pp b/manifests/defaults.pp
index 0e3f416..193eebd 100644
--- a/manifests/defaults.pp
+++ b/manifests/defaults.pp
@@ -28,6 +28,7 @@
$jmx_port = 9999
$log_dirs = ['/var/spool/kafka']
$heap_opts = undef
+ $auto_create_topics_enable = false
$num_network_threads = 2
$num_io_threads = 2
diff --git a/manifests/server.pp b/manifests/server.pp
index 2ddf3a6..15cb318 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -31,6 +31,10 @@
#
# $jmx_port - Port on which to expose JMX metrics.
Default: 9999
#
+# $heap_opts - Heap options to pass to JVM on startup.
Default: undef
+#
+# $auto_create_topics_enable - If autocreation of topics is allowed.
Default: false
+#
# $num_network_threads - The number of threads handling network
# requests. Default: 2
#
@@ -87,9 +91,10 @@
$zookeeper_chroot = $kafka::defaults::zookeeper_chroot,
$jmx_port = $kafka::defaults::jmx_port,
- $num_partitions = $kafka::defaults::num_partitions,
$heap_opts = $kafka::defaults::heap_opts,
+ $auto_create_topics_enable =
$kafka::defaults::auto_create_topics_enable,
+
$num_network_threads = $kafka::defaults::num_network_threads,
$num_io_threads = $kafka::defaults::num_io_threads,
$socket_send_buffer_bytes =
$kafka::defaults::socket_send_buffer_bytes,
diff --git a/templates/server.properties.erb b/templates/server.properties.erb
index 4844f51..35538ea 100644
--- a/templates/server.properties.erb
+++ b/templates/server.properties.erb
@@ -46,6 +46,15 @@
# Default to the number of log.dirs.
num.partitions=<%= Array(@log_dirs).length %>
+# The default replication factor for automatically created topics.
+# Default to the number of brokers in this cluster.
+default.replication.factor<%= @brokers.keys.length %>
+
+# Enable auto creation of topic on the server. If this is set to true
+# then attempts to produce, consume, or fetch metadata for a non-existent
+# topic will automatically create it with the default replication factor
+# and number of partitions.
+auto.create.topics.enable=<% @auto_create_topics_enable %>
############################# Log Flush Policy #############################
--
To view, visit https://gerrit.wikimedia.org/r/102573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee8f0117e9d5c170a747729e0e75471948366d09
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/kafka
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
